search

UofS-Pulse-Binfo / analyzedphenotypes

Tripal/Drupal support for analyzed phenotypic data including data loaders, exporters, trait pages and summaries on germplasm pages.
GNU General Public License v2.0
0 stars 1 forks source link

74 download fix #75

Closed reynoldtan closed 5 years ago

reynoldtan commented 5 years ago

This PR will fix average rep issue where related rows (related by experiment, germplasm, year and location) are not merged into a single row.

Screen Shot 2019-03-27 at 9 27 09 AM Image shows averaged across replicate but listing 2 rows instead of one row for the same experiment, germplasm, year and location.

This PR also disabled Max missing data field option since this is currently not implemented and field does not have any effect on the exported file. Screen Shot 2019-03-27 at 10 56 30 AM

Metadata

Documentation:

Description

Dependencies

Testing?

Simply download data and select multiple traits and germplasm. Make sure to check off Screen Shot 2019-03-27 at 10 58 33 AM

Take note of the options selected and repeat the process except this time uncheck Average Replicate option to export all records then compare both results Screen Shot 2019-03-27 at 11 10 39 AM .

Tip: To easily see data in rows and column, set the file type to XLSX - excel.

laceysanderson commented 5 years ago

@reynoldtan the streamlined download code is now ready to test. I've removed the option to download non-averaged reps on the download form. There should now only be one row for each unique experiment-germplasm-location-year combination. This means there should be multiple traits shown on the same row of the file.

laceysanderson commented 5 years ago

PS. Also note #77 has already been reported and will be worked on separately.

reynoldtan commented 5 years ago

  1. The update works for exported file as tsv and csv but when set to xlsx, the result does not contain the column header part. Screen Shot 2019-05-01 at 10 15 49 AM

  2. Result does not follow the order of headers selected. It is always in this order: Traits, Germplasm Name, Year and Location. Also, it excludes other optional header that you add to default headers (ie: country of origin, data collector).

laceysanderson commented 5 years ago

Result does not follow the order of headers selected. It is always in this order: Traits, Germplasm Name, Year and Location. Also, it excludes other optional header that you add to default headers (ie: country of origin, data collector).

This is a separate bug and is evident on the master branch as well. It is documented in Issue #77.

reynoldtan commented 5 years ago

Header issue with xlsx type now fixed.

laceysanderson commented 5 years ago

Great, Thanks for the review!