add terms necessary for module

UofS-Pulse-Binfo / genotypes_loader

A Drush-based loader for VCF files that follows the genotype storage rules outlined by ND genotypes.

GNU General Public License v2.0

1 stars 2 forks source link

add terms necessary for module #35

Closed bradfordcondon closed 5 years ago

bradfordcondon commented 5 years ago

Metadata

Issue #34

[ ] I feel this PR is ready to be merged.
[x] This PR is dependent upon [PR #/ nothing]

Documentation:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Description

I think for the module rating requirements, all terms used by this module should be inserted on install. I think its a big grayer because you allow for custom terms, but, I still think inserting the default terms and notifying the user that they can change them is the right move.

bradfordcondon commented 5 years ago

note that with #36 looks like one of the term CVs is wrong and both this and the README should be updated.

laceysanderson commented 5 years ago

We had originally left this out since we wanted users to configure the terms... That said, we've decided that our defaults should be good enough that people should be able to choose not to configure. With that in mind, there is no harm inserting them on install while still allowing them to change them later.

Thus, Thank you @bradfordcondon for the PR and the issue! I'm going to merge this into a branch so I can quickly fix the one term and add a message to configure before merging into master.

bradfordcondon commented 5 years ago

thanks @laceysanderson ! do whatever is easiest- i dont mind losing the commit credit.