Closed laceysanderson closed 7 years ago
$arr_rows[] = array();
with each element on it's own line.$query->fetchAll()
since it pulls all files into memory. Instead you can iterate over the results directly foreach ($result_F as $f) {
(see https://www.drupal.org/docs/7/api/database-api/result-sets).array(element1, element2);
instead. (You use square brackets more then once... but not always -be sure to be consistent)!important
. You can almost always accomplish the same thing by using more selective CSS rules. Using !important makes it more difficult for others to override your styles which makes your module less friendly for sharing.I tested all the new functionality through the interface and it performs as expected 👍
My only comment from a non-code based perspective is that both the upload and download Tripal jobs print excessively to the screen. This greatly slows down the job. I would print an update at most every 10% and otherwise I would only print errors. Upload is printing for every line and even download is printing ~3 times per 5% (looks like a rounding error).
Back to you @reynoldtan for improvements.
Changes are merged into the main branch 👍
Changes: https://github.com/UofS-Pulse-Binfo/rawphenotypes/compare/cb18bae00690eb9ecb4b52a5389d1df43e81387e...master
Check: #3, #4, #5.