A Tripal module for storing raw phenotypic data. Specifically meant to help researchers contribute raw data, visualize summaries and download for further analysis.
2
stars
2
forks
source link
Issue #23 - Allow Not Applicable values (n/a, na or n.a.). #24
Data collectors encounter difficulty submitting data due to cell values containing different variations of Not Applicable (na, n/a). Recently, a spreadsheet file containing information that requires some column headers be set to Not Applicable has to be submitted to the server. This update will allow such requirements into the system.
Fixes:
During validation of cell values (in file_validate hook and validate_excel_file), any instance of not applicable value is converted first to NA for consistency (module uses NA variation for processing, downloading and storing data). Next, the NA value is then submitted to registered validators (of scope all and subset) to check if phenotype it is in permits such value or not. A validation error is generated when column is set to not allow NA. Otherwise user is instructed to proceed to next stage of the process.
Please note that this update applies to backup as well, since both upload and backup use the same set of validators.
Testing:
Download/Prepare a standard phenotyping spreadsheet file.
Add na, NA, n/a, N/A, n.a, or N.A. to any phenotype except Planting Date and Name (germplasm) columns.
Upload or backup the file.
To test errors: set value to naa, n*a, naaa or other character values that do not match NA, N/A, N.A., regardless of the case.
Please Note: Planting Date and Name remain required column - must have value, YYYY-MM-DD for planting date and no NAs allowed.
Data collectors encounter difficulty submitting data due to cell values containing different variations of Not Applicable (na, n/a). Recently, a spreadsheet file containing information that requires some column headers be set to Not Applicable has to be submitted to the server. This update will allow such requirements into the system.
Fixes: During validation of cell values (in file_validate hook and validate_excel_file), any instance of not applicable value is converted first to NA for consistency (module uses NA variation for processing, downloading and storing data). Next, the NA value is then submitted to registered validators (of scope all and subset) to check if phenotype it is in permits such value or not. A validation error is generated when column is set to not allow NA. Otherwise user is instructed to proceed to next stage of the process.
Please note that this update applies to backup as well, since both upload and backup use the same set of validators.
Testing:
Please Note: Planting Date and Name remain required column - must have value, YYYY-MM-DD for planting date and no NAs allowed.