search

UofS-Pulse-Binfo / rawphenotypes

A Tripal module for storing raw phenotypic data. Specifically meant to help researchers contribute raw data, visualize summaries and download for further analysis.
2 stars 2 forks source link

Summary Barchart incorrectly states "No Data" #29

Closed laceysanderson closed 6 years ago

laceysanderson commented 6 years ago

I found this bug during the Tripal 3 upgrade but it is not related to the Tripal version.

Symptom: The summary barchart displayed at phenotypes/raw when a trait is chosen, says there is no data when there is. This was experienced consistently for all traits on a KP clone site but not on the production site.

laceysanderson commented 6 years ago

After some digging it, I noticed the issue was related to the data query in rawpheno_function_create_json; specifically, when pulling out the cvterm_id for 'location'. There are two cvterms with the name 'location' in KP and the clone was pulling out the wrong one.

laceysanderson commented 6 years ago

Accidentally committed directly to master :-( I would still like you to both look at the change though.

Testing: Go to the raw phenotypes summary page and choose a chart on a site with this commit. The barchart should show up as expected. Unfortunately the bug itself is only repeatable by chance when a new clone is created since LIMIT 1 on an unordered query depends on the order stored on disk. That's why this is not seen on the production site.

reynoldtan commented 6 years ago

Checked and tested summary page.