UofS-Pulse-Binfo / rawphenotypes

A Tripal module for storing raw phenotypic data. Specifically meant to help researchers contribute raw data, visualize summaries and download for further analysis.
2 stars 2 forks source link

WSOD of Download page #33

Closed laceysanderson closed 6 years ago

laceysanderson commented 6 years ago

I'm experiencing a WSOD on the download page (phenotypes/raw/download) of my Tripal2 KnowPulse clone. It appears to be related to an empty location being passed to rawpheno_download_load_traits and fed directly into the SQL query. This results in the following PDO Exception: screen shot 2018-02-07 at 3 06 18 pm

laceysanderson commented 6 years ago

NOTE: There's too things to fix here. First, there should always be a check that parameters exist before passing into a query. Second, why are we getting an empty location when a default should have been chosen?

reynoldtan commented 6 years ago

The error is in the query to search default or all locations line #85 of rawpheno.download.form.inc. The query assumed that there is only one term 'Location' in chado.stock table. To fix the issue, modify the query and ensure to use the term 'Location' that is in or of type phenotype_measurement_types controlled vocabulary.

reynoldtan commented 6 years ago

Checked and tested revised queries.