Issue # 64 - Download page updates

reynoldtan commented 5 years ago

Show env option by default
improved page load time
Removed all projects option
Added default project (latest with data first)

reynoldtan commented 5 years ago

PR# 65 - Download page updates

Set include environment data option to always show as opposed to hiding or showing it when option applies. When environment data file is available, the option will become available or disabled otherwise.
Omitted the option to download data from all projects that will also allow export of all environment data file per location in each project (data + file overload).
Sorted projects in select project filter based on the planting year. The first option or the default option indicated the project with the most recent planting year.
Improved overall page load time and while selecting filter.

Metadata

Issue # 64 - [https://github.com/UofS-Pulse-Binfo/rawphenotypes/issues/64]

[X] I feel this PR is ready to be merged.
[ ] This PR is dependent upon [PR #/ nothing]

Documentation:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation. Only to say that environment data file can be incorporated to the exported data by checking off the include environment data file option preceding the R Friendly trait names option.
[ ] I have updated the documentation accordingly.

Description

Dropped the option "All projects" from select project option and modified the query that generates projects to inspect which got a recent data upload (latest planting year) and push it to the top of the list of projects.

Environment data file option disables or enables base on whether the filter combination returns a file or not. This is achieved by adding a query to check if year+location+project returned a file. A script attached listens for event and uses the check value to enable or disable evn. data option.

Improved page load time by utilizing a table (materialized view) containing a summarized data of all raw phenotypes to load trait set given a location + project.

Dependencies

no dependencies.

Testing?

I compared page load time of download page in portal versus KP clone and accessed projects available in either sites and compared the set of traits available for export. In both trials, page load time with this PR is faster than that in portal and traits appear to be the same.

Note: This PR now sorts the traits in alphabetical order.

A simple example: screen shot 2018-10-01 at 2 22 36 pm 2 Left is dev with this PR and right is portal.

The first option in select project filter indicates the project with the recent planting year. Upload a spreadsheet file with different planting year into a different project to alter the order and let that project be the first option.

Environment data option enables and disables based on whether a combination of filter correspond to an environment data file or not.

[ ] I tested on a generic Tripal Site
[X] I tested on a KnowPulse Clone in dev/A
[ ] This PR includes automated testing

carolyncaron commented 5 years ago

Firstly, thank you so much for filling out the template for this PR, even though it came before the PR templates were a thing! 🤗 This made reviewing much easier for me.

All of my testing was done on dev/fresh. Because this dev site appears to be a couple of months old, I would like to re-test the functionality on a truly fresh site before approving this PR. That said, all of the changes appear to work as described and are a huge improvement to the module. From what I can tell, no bugs have been introduced.

I see that Lacey has made some comments on the code as well. Once those have been addressed I will re-test everything on a fresh site 👍

reynoldtan commented 5 years ago

Revised query to speed up data download page. Back to you Lacey.

UofS-Pulse-Binfo / rawphenotypes