search

UofS-Pulse-Binfo / rawphenotypes

A Tripal module for storing raw phenotypic data. Specifically meant to help researchers contribute raw data, visualize summaries and download for further analysis.
2 stars 2 forks source link

Collecting data for plots that are segregating. #7

Open laceysanderson opened 7 years ago

laceysanderson commented 7 years ago

Some of our plots are segregating for specific phenotypes. For example, some plots might be segregating for flower colour (e.g. white/purple) or days to flower (e.g. 42/59 days). In these cases, some data collectors will record both phenotypes they observed (as shown in brackets above). Kirstin feels the loader should handle this.

reynoldtan commented 7 years ago

I don't see any problem with traits with text unit, but for numeric units such as count, days, centimeters and grams (we coded it to expect positive whole numbers, plus scale which is 1-5), yes the module will detect this as an error. A workaround might be to just set the unit to anything relevant (e.g. Flower Colour (colour), Days to Flower (seg-days) or (#ofdays) etc.) but the list of unit mentioned under numeric.

For existing AGILE trait, an option would be to record both values in separate rows and let the download page group the values, or in terms of code, we can tell the module to be a little tolerant if it detects "/" or "," (or other chars that connote an enumeration/segregation) when recording numeric values.

Please advice

laceysanderson commented 7 years ago

I think we should make the module more tolerant.

Solution:

When checking if a numeric value is numeric: If it fails then check if there is a "/" or "," character and that the remaining characters on either side of such a symbol are numeric.

laceysanderson commented 7 years ago

I would prioritize #15 and #8 before working on this.