search

UofS-Pulse-Binfo / rawphenotypes

A Tripal module for storing raw phenotypic data. Specifically meant to help researchers contribute raw data, visualize summaries and download for further analysis.
2 stars 2 forks source link

Warning on Upload page #8

Open laceysanderson opened 7 years ago

laceysanderson commented 7 years ago

There has been some confusion between the upload and backup pages since they look so similar. As such, it might be prudent to add a warning to the upload page indicating that this should only be done once per dataset once data collection has been completed. It would be helpful to point them to the backups page.

carolyncaron commented 6 years ago

In addition to this, we are concerned that users may still attempt to upload the same file more than once without realizing that all versions would then be added to the database. Perhaps the system could detect additional upload attempts from the same account within a specified timeframe, and provide a warning that if they made corrections to a file that has already been uploaded, to please contact us rather than uploading again.

Our real-life example of this is one collaborator who initiated an upload, made it to stage 2 but realized they were missing a new trait in their file that they wished to define. We suspect they hit the back button to return to step 1, uploaded their newly edited file and continued to the last step. Fortunately, we have just one copy of the data stored in the database but there was nothing to prevent them from reaching the final step and THEN returning to upload their additional column (with all previously uploaded columns still filled in!!!) and this would have created a nightmare to resolve if we didn't catch it right away.

This is a tricky problem since we don't want to discourage multiple uploads if the files originated from different phenotypers (who potentially share the same account), or multiple files with blank columns, such that when all files are uploaded, every column is filled in only once (also likely due to multiple phenotypers but not a given).

laceysanderson commented 6 years ago

@reynoldtan was this closed because it's been done? And if so, can you point to a commit or pull request?

reynoldtan commented 6 years ago

@laceysanderson I don't recall, but I think it was not done due to @carolyncaron comments required more clarification/discussion and might be difficult to implement. Let's reactivate this issue. Please review text for the warning message:

File upload to this page should only be done once per dataset once data collection has been completed. To create a backup copy of your spreadsheet file, please go to Backup Page.

reynoldtan commented 6 years ago

@carolyncaron and @laceysanderson for preventing a user from uploading file/data more than once.

Suggestions:

  1. Detect back button as in your example as an attempt to upload twice or just having problem uploading thus we warn the user to contact us.
  2. Check the first x number of rows of the file and see if it matched in the system, then we can tell that the same file/data was previously uploaded. Taking into consideration the person uploading, job queue and date.
  3. Stop user from initiating upload job simultaneously.
laceysanderson commented 6 years ago

Hmmm... hold off on this one reynold. Too much on my plate to consider it properly.