Comments on base structure

[laceysanderson]

Changes

• Add tripal_ws as a dependency to the module.
• Make sure that other developers can override a single BrAPI call in their own module without having to duplicate all the code. This is needed to handle the case where they store their data differently but only for a single call.
• Users should be able to access [base]/v1/[...]/calls as well as [base]/v2/[...]/serverinfo without needing to change configuration. This is needed to support the maximum number of BrAPPs
• This module should only handle BrAPI and should use the Tripal web services where possible.

Comments

• hook_menu and tripal_ws_vocabulary_handle_request look good 👍 I like their simplicity.
• Overall class structure looks good 👍
• Functional Test 👍

Next Steps

• This is a good point to start a "Developers Handbook" explaining the class structure of the module and the flow of methods.
• Automated testing for the current classes.

[laceysanderson]

This has been addressed. Still no automated testing though.