search

UofT-HPRC / galapagos

MIT License
12 stars 11 forks source link

Bizarre (and otherwise undocumented) User IP repository paths in make_shell.tcl #6

Open esophagus-now opened 4 years ago

esophagus-now commented 4 years ago

Check out these lines: https://github.com/UofT-HPRC/galapagos/blob/master/shells/tclScripts/make_shell.tcl#L112-#L115

As far as I can tell, these are the only lines which will add IP repository paths to a Galapagos project. This means that the user has to put all their repositories in the $galapagos_dir/shells/userIP folder.

Assuming that this is correct, this fact should be made apparent in the Galapagos documentation.

By the way, the other two ip repo paths that this command tries to add are

$galapagos_dir/hlsBuild
$galapagos_dir/shells/shell_ips

The first one makes sense, but I don't think the second one is used anymore.

esophagus-now commented 4 years ago

Wait, I'm an idiot. I was looking for the shell_ips folder yesterday but for some reason I didn't notice it.

By the way, I realized last night that you said you were planning to fix up the logical file syntax. My original to just edit the documentation is kind of dumb; it would be better to allow the user to put some kind of <path> tags to indicate where the IP is situated.