Lec06 - Githubissues

smile4life commented 5 years ago

Uploading lecture six and corresponding data files

James-S-Santangelo commented 5 years ago

Updates to lec06 look great! I'm pumped for this class. Just a couple quick comments:

Travis is failing because the datasets downloaded in lec06 are not on the GitHub repository. The easiest solution is to submit a separate PR first with just the datasets.
This PR includes all commits already merged into master since the beginning of the course. I think it's likely your fork was not up to date with rcourse/master

I think we need to:

Make sure your fork is up to date (by running git pull upstream master). Once master is up to date, you can create a new branch from master and go to 1 and 2.
Commit 3 datasets for lecture 6 as first PR.
Submit PR for lecture 6.

smile4life commented 5 years ago

The data sets do seem to be there - it looks like it failed because the files I specified were in the format "" instead of "data/" 🤦‍♀

UofTCoders / rcourse