Up-Mods / AnvilFix

Removes the Max level Limit and Cumulative Repair Cost from Anvils
https://www.curseforge.com/minecraft/mc-mods/anvil-fix
8 stars 11 forks source link

Mod Breaks Quark's Tomes merging cost #6

Closed Insane96 closed 5 years ago

Insane96 commented 5 years ago

Issue Description:

When I try to merge an book and a tome from Quark (and then the resulting book and an item) instead of costing 35 levels it will cost only 1.

What happens:

2019-05-09_08 43 29

What you expected to happen:

The merge to cost 35 levels.

Steps to reproduce:

  1. Try to merge an enchanted book with the relative Quark Tome
  2. Profit

Affected Versions (Do not use "latest"):

Possibly Conflicting Mods (Provide their version, as well):

Reported to Quark too: https://github.com/Vazkii/Quark/issues/1250

DoomRater commented 5 years ago

This also seems to happen when PiTweaks makes changes to the anvil as well. I used PiTweaks to allow overlevelling of books and force setting the repair count to 0 as well as allowing enchantments to be applied regardless of tool choice or previous enchantments. But when I combined your mod with PiTweaks, all Enchantments became 1 Level to apply.

PiTweaks version used: [1.12-1.1.1]

Insane96 commented 5 years ago

Repair cost can't be below 1 as how the anvil is coded

Il giorno lun 17 giu 2019 alle ore 08:16 Brach Speicher < notifications@github.com> ha scritto:

This also seems to happen when PiTweaks makes changes to the anvil as well. I used PiTweaks to allow overlevelling of books and force setting the repair count to 0 as well as allowing enchantments to be applied regardless of tool choice or previous enchantments. But when I combined your mod with PiTweaks, all Enchantments became 1 Level to apply.

PiTweaks version used: [1.12-1.1.1]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NerdHubMC/AnvilFix/issues/6?email_source=notifications&email_token=ABW2FUE6F4COETIDISOPS23P24T3PA5CNFSM4HLXTBD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2ESRA#issuecomment-502548804, or mute the thread https://github.com/notifications/unsubscribe-auth/ABW2FUHCK2ZEZIATAD2DAYDP24T3PANCNFSM4HLXTBDQ .

-- Del Villano Alberto

DoomRater commented 5 years ago

My comment has nothing to do with wanting repair costs to be 0. PiTweaks forces the repair COUNT to 0 so that repair costs never increase.

p455w0rd commented 5 years ago

due to the AnvilUpdate event not passing the container instance or any player refs, this mod simply cannot be compatible with quark