Up-Mods / Icarus

Minecraft mod that adds a bunch of colourful and unique wings
https://curseforge.com/projects/428151
Other
11 stars 11 forks source link

Client and server durability config syncing #54

Closed KLONOA9X6 closed 1 year ago

KLONOA9X6 commented 1 year ago

As the title, Icarus mod can't sync the config between client and server, that caused if you set the durability on server and don't change client config, when durability is reduced to 1, the wings will still usable until the wings completely damage and disappear.

CammiePone commented 1 year ago

Minecraft and Icarus versions, please

KLONOA9X6 commented 1 year ago

Minecraft: 1.19.2 (Fabric 0.14.19) Icarus: https://github.com/KLONOA9X6/Icarus/commit/eca9397cea0c47754d9e5e31b3ff83b5f92f2444

CammiePone commented 1 year ago

this was fixed in 1.19.3 and it wont be backported, so uh... update i guess?

KLONOA9X6 commented 1 year ago

Arr...I found it (Branch 1.19.2-suffering). image Looks like you made a mistake

CammiePone commented 1 year ago

durability is not something you can change on the fly. thats set during registry, and Mojang hasnt made items a dynamic registry. it would require a game restart to go into effect

KLONOA9X6 commented 1 year ago

Arr... It looks a little difficult... But I think this glitch is not only on 1.19.2 branch, but also on other branch...

CammiePone commented 1 year ago

its not a glitch, its technically impossible. even if I wanted to sync the durability, it literally cant be.

KLONOA9X6 commented 1 year ago

I'm a little bit to describe the problems that may occur

Server config: 500 durability Client config: 0 (infinity)

When damage value to 499, client will not stop flying, it will continue flying until the wing completely damaged and disappear.

KLONOA9X6 commented 1 year ago

Well, forget it, I will build a separate version with modified durability values for the server to use

CammiePone commented 1 year ago

its literally not possible. an item's durability cant be changed while the game is running. what do you not understand about that

KLONOA9X6 commented 1 year ago

I know, I did before and I know that's impossible