Up-Mods / OkZoomer

Adds a highly-configurable zoom key. The zoom is yours!
133 stars 25 forks source link

Consider rethinking the server-side component #40

Closed Madis0 closed 3 weeks ago

Madis0 commented 3 years ago

Zooming is:

Therefore, despite the addition of spyglasses, I think it does not make sense for servers to be able to limit it as much as you have defined now in ZoomPackets.java.

Instead, I suggest keeping most of the features configurable client-side and only giving the servers a way to disable options that would not be available with vanilla FOV/Optifine settings.

Namely:

This way users can confidently use zoom in every server and servers that use this can be sure that users only use zoom within the vanilla limits.

EnnuiL commented 3 years ago

Hm, this is a complicated issue, because Ok Zoomer was simply meant as a replacement for OptiFine zoom, I don't want it to be seen as an "utility" mod that is in reality a hack or something and I don't want people to be banned over it; That's why the restrictions exist, although I've been careful to not have cosmetic features like zoom transitions be affected by them.

So far, I think most of the current packets do fit into the "Neither OptiFine nor Vanilla" camp (specially the "Force Classic Mode" one), although I could think about the "Disable Zoom" one and scrap it, i don't know, i just don't want anyone banned over this mod

The possibility for spyglass-related packets are something that I've been considering and I do want to add them, and if I do end doing something related to an increased render distance, I'll add options for the server, although I'll probably only tinker with that on 1.18 since it has the render/simulated distance split

I'll think about removing the "Disable Zoom" packet and working on new ones later

Madis0 commented 3 years ago

I understand your concerns about the bans, but realistically it is not worth it to disable anything that Optifine can do, because I have not heard of any server that would ban Optifine itself. The scrolling feature could seem like a hack, but since it only takes 3 clicks to change the FOV, it is replicable without the mod anyway, the mod only makes it a bit faster.

Thanks for considering this.

EnnuiL commented 3 weeks ago

The system was broken since Minecraft 1.20.6; I was considering trimming down the system to "Force Spyglass Restriction" since I have thought of this and yeah.. disabling zoom, zoom scrolling and such? That was silly; But well? This system was broken since Minecraft 1.20.6. Over 400k people have played a mod that had this system broken, and yet I had to deal with the shadow of this boogeyman all this time.

The paranoia can cease now, the paranoid woman's system has been removed in 10.0.0-beta.3. Let the paranoia over who's gonna take the throne begin.