search

UpCloudLtd / upcloud-ansible

Dynamic inventory and modules for managing servers via UpCloud's API
50 stars 17 forks source link

Add support for state = stopped #12

Closed villesavolainen closed 3 years ago

villesavolainen commented 7 years ago

Adds new 'stopped' state to server state attribute.

mlackman commented 7 years ago

Thanks for the contribution!

I tried the PR and I found couple of problems. 1) It does not wait the server to become stopped. 2) Going back from stopped state to present does not seem to work, because of the default timeout is too short.

I would suggest that the timeout is increased in the module/uplcoud.py (CloudManager constructor). Also the code should wait the server to go to stopped state before stating that the operation is successfully done

iler commented 7 years ago

@villesavolainen have you had time to revise the PR according to the comments given above?

PopoSensei commented 3 years ago

Closing since been such a long time.