search

UpCloudLtd / upcloud-cli

UpCloud command line client (upctl)
https://upcloudltd.github.io/upcloud-cli/
MIT License
29 stars 7 forks source link

Disable colors if `NO_COLOR` env variable is set #150

Closed kangasta closed 2 years ago

aakso commented 2 years ago

Perhaps rename the var to NO_COLOURS for consistency with the flag? Of course we could have both spellings.

kangasta commented 2 years ago

Many other CLI apps use NO_COLOR so for compatibility it would be better even though it looks a bit odd that we use US spelling for env variable but not in options.

kangasta commented 2 years ago

We might as well check for both spellings to be both consistent and compatible, but not sure if that would cause more confusion.