fix(filesystem): remove FS type constraints

UpCloudLtd / upcloud-csi

Container Storage Interface (CSI) driver for UpCloud's MaxIOPS storage offering

MIT License

13 stars 0 forks source link

fix(filesystem): remove FS type constraints #86

Closed peknur closed 1 year ago

peknur commented 1 year ago

Fixes:

remove ext filesystem requirement to support other types
remove potentially dangerous -F mke2fs option

Changes:

removed obsolete upcloud-csi-manifest command and objgen package
removed required variables from Kubernetes deployments
updated Go from 1.19 to 1.20
updated UpCloud SDK from v6.0.0 to v6.6.0
new example on how to use XFS filesystem with custom mount options
updated Github actions

peknur commented 1 year ago

@ajmyyra thanks for the review! Yep, we need to validate that value against supported types, just get more descriptive error message (I believe we have ticket for this already). We check that actual command generated from FS type (fmt.Sprintf("mkfs.%s", fsType)) exists so, I think that there is no immediate danger of having injected command, but nevertheless, good to validate.

@nate-droid thanks for the review :+1: