UpCloudLtd / upcloud-go-api

Go client for UpCloud's API
https://pkg.go.dev/github.com/UpCloudLtd/upcloud-go-api/v6
MIT License
42 stars 9 forks source link

refactor: remove `Timeout` option from `WaitFor*` methods #291

Closed kangasta closed 9 months ago

kangasta commented 9 months ago

This is to remove duplicate timeouts: the context.Context parameter passed in to the WaitFor* methods might already have an timeout defined. Thus, the Timeout field might cause confusing errors when, for example, the timeout defined in Timeout field is shorter than timeout defined in the context passed in from e.g. Terraform.