search

UpCloudLtd / upcloud-whmcs-module

A module for integrating UpCloud's services with WHMCS web hosting platform
MIT License
9 stars 11 forks source link

SSH key regular expression is too restrictive #40

Open scop opened 2 weeks ago

scop commented 2 weeks ago

The regular expression used to validate SSH public key to use is too restrictive, it allows RSA keys only, and disallows ed25519 ones among others.

https://github.com/UpCloudLtd/upcloud-whmcs-module/blob/bde802af992426fdb2e132d38c77be91a94e9a0c/modules/servers/upCloudVps/lib/configOptions.php#L201

I wonder if this validation would be better off removed altogether, and have the UpCloud API do its validation on it? I'd say this would be the way to go if it yields good enough UX on errors.

adityawbwce commented 1 week ago

This will be replaced if we are addressing issue #44