search

Updated-NoCheatPlus / NoCheatPlus

Anti-cheating plugin for Minecraft (1.5-1.21, Bukkit/Spigot)
https://ci.codemc.io/job/Updated-NoCheatPlus/job/Updated-NoCheatPlus/
GNU General Public License v3.0
483 stars 101 forks source link

Falling on slime block after a teleport = fall damage. #12

Open Lysandr0 opened 4 years ago

Lysandr0 commented 4 years ago

(Posting most of the issues that have been reported on Discord)

Full output of /ncp version

[INFO] ---- Version information ----

[INFO] #### Server ####

[INFO] git-Spigot-2040c4c-d07a78b ~MC: 1.15.2~

[INFO] detected: 1.15.2

[INFO] #### NoCheatPlus ####

[INFO] Plugin: 3.17-SNAPSHOT-b1153-CustomFork

[INFO] MCAccess: 1.13.2-1.15|? / Bukkit-API

[INFO] Features:

[INFO] blocks: BlocksMC1_4 | BlocksMC1_5 | BlocksMC1_6_1 | BlocksMC1_7_2 | BlocksMC1_8 | BlocksMC1_9 | BlocksMC1_10 | BlocksMC1_11 | BlocksMC1_12 | BlocksMC1_13 | BlocksMC1_14 | BlocksMC1_15 | MCAccessBukkitModern

[INFO] checks: FastConsume | Gutenberg | HotFixFallingBlockPortalEnter | AttackFrequency | FlyingFrequency | KeepAliveFrequency

[INFO] defaults: pvpKnockBackVelocity

[INFO] packet-listeners: UseEntityAdapter | MovingFlying | OutgoingPosition | KeepAliveAdapter | SoundDistance | WrongTurnAdapter | NoSlow | Fight

[INFO] Hooks: AllViolations~NCP~ 1.0 | ViolationFrequency~NCP~ 1.0

[INFO] #### Related Plugins ####

[INFO] ProtocolLib v4.5.0 | ProtocolSupport v4.29-dev

Describe the issue

1) Teleporting while falling and landing on slime blocks will still deal fall damage to the player which should be prevented by the block. https://www.dropbox.com/s/biz12z5h565u7m4/nofall%2Bteleport.mov?dl=0 Log: nofallteleport.log

2) Descending in scaffold blocks by shifting can occasionally deal fall damage to the player (Video on Discord) 3) Trying to take off with the elytra while leaving a climbable can lead to a nofall violation although it is really hard to reproduce (Video on Discord)

Any possible config options changed or plugins that may cause interference?

Default config

CaptainObvious0 commented 4 years ago

  1. I can confirm the first issue, need to take a deeper look at how NoFall deals with blocks like slimeblocks.

  2. I was not able to reproduce this issue. A debug log would be required to figure out what the issue is.

  3. Issue has been fixed with commit 72f26af .

Lysandr0 commented 4 years ago

Oddly enough, I couldn't manage to reproduce the 2nd one anymore with the latest version... Except for this: https://www.dropbox.com/s/cknw0iwt3p5z7vj/nofalltest1.mov?dl=0 which should be vanilla behaviour if I'm not mistaken. Falling on the edge of scaffolding will still deal fall damage.

Edit: First issue can be fixed by removing my fix/workaround although this will also bring back that old false positive.