search

Updated-NoCheatPlus / NoCheatPlus

Anti-cheating plugin for Minecraft (1.5-1.20, Bukkit/Spigot)
https://ci.codemc.io/job/Updated-NoCheatPlus/job/Updated-NoCheatPlus/
GNU General Public License v3.0
482 stars 100 forks source link

Scaffold checks allow air place #152

Closed deciduous-buffalo closed 3 years ago

deciduous-buffalo commented 3 years ago

You can quickly toggle on and off scaffold while in mid air and you can place blocks in the air without any adjacent blocks nearby

Lysandr0 commented 3 years ago

BlockPlace.againstshould already prevent this. What's the debug output of it when reproducing the issue? (/ncp debug player [playername] yes:BLOCKPLACE_AGAINST) Will also need the/ncp ver output

Edit: if possible, a video would be great as well :p

deciduous-buffalo commented 3 years ago

[05:01:18] [Server thread/INFO]: »Version information«

[05:01:18] [Server thread/INFO]: git-Airplane-"ec7d3d0" ~MC: 1.17.1~ [05:01:18] [Server thread/INFO]: Detected: 1.17.1

[05:01:18] [Server thread/INFO]: Plugin: 3.17-SNAPSHOT-Updated-b114 [05:01:18] [Server thread/INFO]: MCAccess: 1.13-1.17|? / Bukkit-API

[05:01:18] [Server thread/INFO]: blocks: BlocksMC1_4, BlocksMC1_5, BlocksMC1_6_1, BlocksMC1_7_2, BlocksMC1_8, BlocksMC1_9, BlocksMC1_10, BlocksMC1_11, BlocksMC1_12, BlocksMC1_13, BlocksMC1_14, BlocksMC1_15, BlocksMC1_16, BlocksMC1_17, MCAccessBukkitModern [05:01:18] [Server thread/INFO]: checks: FastConsume, Gutenberg, HotFixFallingBlockPortalEnter, AttackFrequency, FlyingFrequency, KeepAliveFrequency [05:01:18] [Server thread/INFO]: defaults: pvpKnockBackVelocity [05:01:18] [Server thread/INFO]: packet-listeners: UseEntityAdapter, MovingFlying, OutgoingPosition, KeepAliveAdapter, SoundDistance, WrongTurnAdapter, NoSlow, Fight

AllViolations~NCP~ 1.0, ViolationFrequency~NCP~ 1.0 [05:01:18] [Server thread/INFO]: »Related Plugins« [05:01:18] [Server thread/INFO]: ProtocolLib v4.7.0, ViaVersion v4.0.1

This worked on 1.16.5 before I updated as well. I am away from home so I cant really record a video, but if you have Meteor client its extremely easy to reproduce. I just jump into the air off a ledge and toggle on scaffold, and it will place a block if I am not falling fast already

Lysandr0 commented 3 years ago

Should be fixed with 116. If not, please leave a note. Also do note that this build contains some tweaks to Scaffold making it more strict (Yaw speed is now monitored + Scaffold contributes in feeding the Improbable)

deciduous-buffalo commented 3 years ago

Yep, this is fixed now in server restart with the latest version. Thanks