SurvivalFly being falsely triggered when standing/walking over farmland.

LegacyValken commented 3 years ago

Full output of /ncp version

13:07:08 INFO: »Version information«

13:07:08 INFO: git-Paper-266 ~MC: 1.17.1~ 13:07:08 INFO: Detected: 1.17.1

13:07:08 INFO: Plugin: 3.17-SNAPSHOT-Updated-b118 13:07:08 INFO: MCAccess: 1.13-1.17|? / Bukkit-API

13:07:08 INFO: blocks: BlocksMC1_4, BlocksMC1_5, BlocksMC1_6_1, BlocksMC1_7_2, BlocksMC1_8, BlocksMC1_9, BlocksMC1_10, BlocksMC1_11, BlocksMC1_12, BlocksMC1_13, BlocksMC1_14, BlocksMC1_15, BlocksMC1_16, BlocksMC1_17, MCAccessBukkitModern 13:07:08 INFO: checks: FastConsume, Gutenberg, HotFixFallingBlockPortalEnter, AttackFrequency, FlyingFrequency, KeepAliveFrequency 13:07:08 INFO: defaults: pvpKnockBackVelocity 13:07:08 INFO: packet-listeners: UseEntityAdapter, MovingFlying, OutgoingPosition, KeepAliveAdapter, SoundDistance, WrongTurnAdapter, NoSlow, Fight

AllViolations~NCP~ 1.0, ViolationFrequency~NCP~ 1.0 13:07:08 INFO: »Related Plugins« 13:07:08 INFO: ProtocolLib v4.7.0

Describe the issue

When a player walks over farmland, they get violations for SurvivalFly. [12:50:20 INFO]: [NC+] LG_Legacy could be using SurvivalFly VL 210 [12:50:23 INFO]: [NC+] LG_Legacy could be using SurvivalFly VL 454

How to reproduce the issue

Redundant. Walk over farmland with the plugin enabled.

Extra links: video and/or debug log

Player debug when walking over farmland: https://pastebin.com/R3YuEMhT

Any possible config options changed or plugins that may cause interference?

Too many configuration values have been changed to specify completely, mostly they have been tweaked violation levels for notification or disabling kicking/canceling in some cases.

Config: https://pastebin.com/XztmR5Z1

However I am also using Denizen and Depenizen which has NoCheatPlus compatibility.

Lysandr0 commented 3 years ago

Actually, now that I look at the config:

If you're using CaptainObvious' I'd suggest to simply switch to the default one, or make your own. Those are too outdated by now and they not maintained anymore.

Remove these block-shape definition entries in your config:

  MOVING_PISTON: default+ign_passable+ground_height
  DEAD_TUBE_CORAL: default+ign_passable+ground_height
  DEAD_TUBE_CORAL_WALL_FAN: default+ign_passable+ground_height
  DEAD_BRAIN_CORAL: default+ign_passable+ground_height
  DEAD_BRAIN_CORAL_WALL_FAN: default+ign_passable+ground_height
  DEAD_BUBBLE_CORAL: default+ign_passable+ground_height
  DEAD_BUBBLE_CORAL_WALL_FAN: default+ign_passable+ground_height
  DEAD_FIRE_CORAL: default+ign_passable+ground_height
  DEAD_FIRE_CORAL_WALL_FAN: default+ign_passable+ground_height
  DEAD_HORN_CORAL: default+ign_passable+ground_height
  DEAD_HORN_CORAL_WALL_FAN: default+ign_passable+ground_height
  DEAD_TUBE_CORAL_FAN: default+ign_passable+ground_height
  DEAD_BRAIN_CORAL_FAN: default+ign_passable+ground_height
  DEAD_BUBBLE_CORAL_FAN: default+ign_passable+ground_height
  SNOW: default
  PISTON_HEAD: default+ign_passable+ground_height
  LILY_PAD: default+ign_passable+ground_height+height8_1
  FARMLAND: default+ign_passable+ground_height+height8_1
  GRASS_PATH: solid+ground+height100+ground_height
  STEP: solid+ground+xz100+height100+ground_height+ign_passable

then /ncp reload (or restart the server) and see how it goes :)

LegacyValken commented 2 years ago

Ah, I see. I had found a config which was recommended a long time ago and figure it would still work, that is definitely my fault. I'm not too familiar with NCP's config and will look around and learn it in depth at some point.

Lysandr0 commented 2 years ago

Assuming as resolved then.

I'm not too familiar with NCP's config and will look around and learn it in depth at some point.

We do have a Wiki page for this, so that might be useful. :p For questions/support there's also a Discord server.

Updated-NoCheatPlus / NoCheatPlus