Our death messages plugin uses PlayerDeathEvent(MONITOR)#getPlayer#getLastDamageCause#getCause to get cause of player death and then broadcast a message.
But if NCP is installed, #getCause returns DamageCause.CUSTOM instead of DamageCause.FALL if player died from falling. Because of this, the messages are broadcasts wrongly. There was no such problem until the recent updates (< 1.18.1), so most likely the change is somewhere in the latest commits
How to reproduce the issue
Important: This problem never happens if player have operator status or all permissions. It works fine for me, but others are falling and dying with DamageCause.CUSTOM. Also I don't know what permission is related :/
Full output of /ncp version
Describe the issue
Our death messages plugin uses
PlayerDeathEvent(MONITOR)#getPlayer#getLastDamageCause#getCause
to get cause of player death and then broadcast a message.But if NCP is installed, #getCause returns
DamageCause.CUSTOM
instead ofDamageCause.FALL
if player died from falling. Because of this, the messages are broadcasts wrongly. There was no such problem until the recent updates (< 1.18.1), so most likely the change is somewhere in the latest commitsHow to reproduce the issue
Important: This problem never happens if player have operator status or all permissions. It works fine for me, but others are falling and dying with
DamageCause.CUSTOM
. Also I don't know what permission is related :/