Updated-NoCheatPlus / NoCheatPlus

Anti-cheating plugin for Minecraft (1.5-1.20, Bukkit/Spigot)
https://ci.codemc.io/job/Updated-NoCheatPlus/job/Updated-NoCheatPlus/
GNU General Public License v3.0
468 stars 103 forks source link

Falling Block performance issues #347

Open IAISI opened 1 month ago

IAISI commented 1 month ago

Complete output of the ncp version command (please prefer text here)

> ncp version
[22:04:17 INFO]: »Version information«
[22:04:17 INFO]: Server:
[22:04:17 INFO]: git-Sakura-"81399e4" ~MC: 1.20.4~
[22:04:17 INFO]: Detected: 1.20.4
[22:04:17 INFO]: NoCheatPlus:
[22:04:17 INFO]: Plugin: 3.17.1-SNAPSHOT-Updated-b187
[22:04:17 INFO]: MCAccess: 1.13-1.20|? / Bukkit-API
[22:04:17 INFO]: Features:
[22:04:17 INFO]: blocks: BlocksMC1_4, BlocksMC1_5, BlocksMC1_6_1, BlocksMC1_7_2, BlocksMC1_8, BlocksMC1_9, BlocksMC1_10, BlocksMC1_11, BlocksMC1_12, BlocksMC1_13, BlocksMC1_14, BlocksMC1_15, BlocksMC1_16, BlocksMC1_17, BlocksMC1_19, BlocksMC1_20, MCAccessBukkitModern
[22:04:17 INFO]: checks: FastConsume, Gutenberg, HotFixFallingBlockPortalEnter, AttackFrequency, FlyingFrequency, KeepAliveFrequency
[22:04:17 INFO]: defaults: pvpKnockBackVelocity
[22:04:17 INFO]: packet-listeners: UseEntityAdapter, MovingFlying, OutgoingPosition, KeepAliveAdapter, WrongTurnAdapter, NoSlow, Fight
[22:04:17 INFO]: Hooks:
AllViolations~NCP~ 1.0, Citizens2~cncp~ 2.0, CustomEchoPetHook 1.0, CustomNoCheatEnforcerHook 1.0, mcMMO~cncp~ 2.3, ViolationFrequency~NCP~ 1.0
[22:04:17 INFO]: »Related Plugins«
[22:04:17 INFO]: CompatNoCheatPlus v6.6.7-SNAPSHOT-2024_02_15-12_26, ProtocolLib v5.2.1-SNAPSHOT-684, ViaVersion v4.10.3-SNAPSHOT

Short description of the issue and how to reproduce (is it random / always happens / side conditions ?)

Falling blocks cause considerable lag when there are too many, no idea if they could be addressed and how (I'm not too familiar with NCP codebase), but probably something we should bear in mind.

To replicate, use WE/FAWE to create a bunch of blocks of Sand in the air. Turn spark profiler on, break 1 block and let the physics do the rest. Results:

Screenshot 2024-05-17 at 22-03-10 spark

Have you made any (noteworthy) changes to the default configuration of NCP?

No.

Do you run any other special plugins that affect game mechanics next to NC+ (skills, machines, adding/changing blocks, other anti-cheating)?

No.

Provide additional information: for bypasses, vulnerabilities and reproducible issues, we request a debug log. Use GitHub gists or PasteBin or similar for errors and huge logs, or attach a (zip-) file here.

N/A