search

Updownquark / OGame-ROI

Simple Economy Build Sequence Calculator for OGame
Apache License 2.0
0 stars 2 forks source link

Slot bonus should apply to more than basic and mine income #4

Open stevietv opened 3 years ago

stevietv commented 3 years ago

Slot bonus is currently only calculated over the Basic Income and the Mine Income. However this bonus should be applied on total production, this including also:

Evidence:

image

image

Difference between metal production is 68k per hour. 17% (Crawler + Plasma + Collector) = 17% 398k = 68k

Updownquark commented 3 years ago

This is hopefully fixed in v0.9.4. Please test if I missed anything.

The only things the slot bonus should not apply to now are officers and items. Let me know if you think I'm wrong about either or both of those as well.

stevietv commented 3 years ago

seems to work for me now too. For good measure after correlating app with game I added a 10% metal booster. This then only applies 10% to metal mine production only, and doesn't get boosted by other benefits. so your assumption about items is correct. not sure about officers though. btw - how are items added in the app? think that you mentioned its not in the UI as yet?

Updownquark commented 3 years ago

Yeah, that's right. They're accounted for in the production code, but I've never been able to decide where they should go in the UI. Suggestions are welcome.

stevietv commented 3 years ago

I feel like the mines tab would be the best place? three columns for M Boost C Boost and D Boost?

On Sat, 26 Sep 2020 at 22:27, Andrew Butler notifications@github.com wrote:

Yeah, that's right. They're accounted for in the production code, but I've never been able to decide where they should go in the UI. Suggestions are welcome.

On Sat, Sep 26, 2020, 9:09 AM Stevie Robinson notifications@github.com wrote:

seems to work for me now too. For good measure after correlating app with game I added a 10% metal booster. This then only applies 10% to metal mine production only, and doesn't get boosted by other benefits. so your assumption about items is correct. not sure about officers though. btw - how are items added in the app? think that you mentioned its not in the UI as yet?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Updownquark/OGame-ROI/issues/4#issuecomment-699507761>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAN2VJMWKQDCQ4W77XX6BF3SHX73RANCNFSM4R2NER2Q

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Updownquark/OGame-ROI/issues/4#issuecomment-699544199, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIQ3OKVTYWI5JUJEBZAERLSHZFCBANCNFSM4R2NER2Q .

Updownquark commented 3 years ago

Added bonus items. I think I can close this now.

stevietv commented 3 years ago

sorry to re-open this, but it seems slot bonus is applied to items. In app a 10% booster shows 48302 per hour In game a 10% booster shows 56513 per hour discrepancy is 17% (i.e. slot bonus for slot 6)

Updownquark commented 3 years ago

Can you post me a screenshot of your in-game vs in-app resource settings?

stevietv commented 3 years ago

In Game: image

In App

image

As you can see, metal mine in game accounts first for slot bonus before the 10% booster is applied

Updownquark commented 3 years ago

I moved the slot update around a bit and applied it in a different way that I think better matches what the game engine is doing. Please let me know if your numbers match or not.

stevietv commented 3 years ago

slot bonus seems great now. on both metal and crystal. There does seem to be a minor mismatch on crawler and plasma production when a planet has a slot bonus.

  1. Planet with metal slot bonus

image

image

  1. Planet with crystal slot bonus

image image

Updownquark commented 3 years ago

Alright, this should be fixed. Try it out with the latest, please

stevietv commented 3 years ago

on my planet used in example 1, they are now only 1 production off on each line:

image image

however, I would say that your calculator is correct, and the rounding is an error on the display of gameforge. Given that it I add all metal up it comes to 1,085,577 or 1,086M, which gameforge presents as 1,085M (they round down and not off)

Updownquark commented 3 years ago

That annoys me very much, but it points to something I'm doing differently and OGame that will be just slightly harder to fix. I was assuming they're using integers for hourly production, so I am too. It appears they're using floating point values for accumulation and just rounding them down in the production display.

One day I will do this as well, because it bothers me to be off at all. But there are higher priorities.