UpendoVentures / Page-Settings-Editor

This is an editor that allows you to create, edit, and delete custom settings for pages in DNN CMS.
https://upendoventures.com/What/CMS/DNN
MIT License
4 stars 1 forks source link

WS-2022-0161 (High) detected in newtonsoft.json.10.0.3.nupkg, Newtonsoft.Json-10.0.3.21018.dll #67

Open mend-bolt-for-github[bot] opened 1 year ago

mend-bolt-for-github[bot] commented 1 year ago

WS-2022-0161 - High Severity Vulnerability

Vulnerable Libraries - newtonsoft.json.10.0.3.nupkg, Newtonsoft.Json-10.0.3.21018.dll

newtonsoft.json.10.0.3.nupkg

Json.NET is a popular high-performance JSON framework for .NET

Library home page: https://api.nuget.org/packages/newtonsoft.json.10.0.3.nupkg

Path to dependency file: /Modules/PageSettingsEditor/Upendo.Modules.PageSettingsEditor.csproj

Path to vulnerable library: /tmp/ws-ua_20230717013228_GHGMMD/dotnet_DIMSSU/20230717013228/newtonsoft.json/10.0.3/newtonsoft.json.10.0.3.nupkg,/tmp/ws-ua_20230717013228_GHGMMD/dotnet_DIMSSU/20230717013228/Newtonsoft.Json.10.0.3/Newtonsoft.Json.10.0.3.nupkg

Dependency Hierarchy: - :x: **newtonsoft.json.10.0.3.nupkg** (Vulnerable Library)

Newtonsoft.Json-10.0.3.21018.dll

Json.NET

Library home page: https://api.nuget.org/packages/newtonsoft.json.10.0.3.nupkg

Path to vulnerable library: /References/DNN/09.09.00/Newtonsoft.Json.dll

Dependency Hierarchy: - :x: **Newtonsoft.Json-10.0.3.21018.dll** (Vulnerable Library)

Found in HEAD commit: 8727e4bba1fb8bb6a2721c00a891d080c7f11b90

Found in base branch: main

Vulnerability Details

Newtonsoft.Json prior to version 13.0.1 is vulnerable to Insecure Defaults due to improper handling of expressions with high nesting level that lead to StackOverFlow exception or high CPU and RAM usage. Exploiting this vulnerability results in Denial Of Service (DoS). \n\nThe serialization and deserialization path have different properties regarding the issue.\n\nDeserializing methods (like `JsonConvert.DeserializeObject`) will process the input that results in burning the CPU, allocating memory, and consuming a thread of execution. Quite high nesting level (>10kk, or 9.5MB of `{a:{a:{...` input) is needed to achieve the latency over 10 seconds, depending on the hardware.\n\nSerializing methods (like `JsonConvert.Serialize` or `JObject.ToString`) will throw StackOverFlow exception with the nesting level of around 20k.\n\nTo mitigate the issue one either need to update Newtonsoft.Json to 13.0.1 or set `MaxDepth` parameter in the `JsonSerializerSettings`. This can be done globally with the following statement. After that the parsing of the nested input will fail fast with `Newtonsoft.Json.JsonReaderException`:\n\n``` \nJsonConvert.DefaultSettings = () => new JsonSerializerSettings { MaxDepth = 128 };\n```\n\nRepro code:\n```\n//Create a string representation of an highly nested object (JSON serialized)\nint nRep = 25000;\nstring json = string.Concat(Enumerable.Repeat(\"{a:\", nRep)) + \"1\" +\n string.Concat(Enumerable.Repeat(\"}\", nRep));\n\n//Parse this object (leads to high CPU/RAM consumption)\nvar parsedJson = JsonConvert.DeserializeObject(json);\n\n// Methods below all throw stack overflow with nRep around 20k and higher\n// string a = parsedJson.ToString();\n// string b = JsonConvert.SerializeObject(parsedJson);\n```\n\n### Additional affected product and version information\n**The original statement about the problem only affecting IIS applications is misleading.** Any application is affected, however the IIS has a behavior that stops restarting the instance after some time resulting in a harder-to-fix DoS.**

Publish Date: 2022-06-22

URL: WS-2022-0161

CVSS 3 Score Details (7.5)

Base Score Metrics: - Exploitability Metrics: - Attack Vector: Network - Attack Complexity: Low - Privileges Required: None - User Interaction: None - Scope: Unchanged - Impact Metrics: - Confidentiality Impact: None - Integrity Impact: None - Availability Impact: High

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Upgrade version

Release Date: 2022-06-22

Fix Resolution: Newtonsoft.Json - 13.0.1;Microsoft.Extensions.ApiDescription.Server - 6.0.0


Step up your Open Source Security Game with Mend here