UpliftGames / wally

Wally is a modern package manager for Roblox projects inspired by Cargo
https://wally.run
Mozilla Public License 2.0
313 stars 102 forks source link

`Wally search` should be useable without `wally.toml` in directory #139

Open Barocena opened 1 year ago

Barocena commented 1 year ago

currently Wally search command does not work if the terminal is not in project directory

it would be a cool QoL change if it is possible

u-train commented 1 year ago

my 2c:

It's a technical reason, but to search, Wally needs to know what registry to search in. Right now, your manifest file would specify that, hence the dependence.

But, we can assume that people will be searching in Uplift's registry 99% of the time. Could also provide an optional argument in the rare case someone wants to search in some alternative registry.

Is it worth adding? Especially because there is a website to search for packages.

magnalite commented 1 year ago

Yeah I'm really unsure what to do about this one. In general we should avoid any assumptions about which registry the user wants to use, this is why this currently doesn't work. Additionally, as u-train pointed out, there is also the website which provides an easy way to search the pubic registry already.

That said, if a blind search is asked for then it is exceedingly likely the user just wants to search the public registry so this would be a nice and easy QoL change. We can bench this for later but I think we should decide on a final outcome before we hit 1.0.0.

LastTalon commented 1 year ago

I think having a clear order of something like command line argument -> environment variable -> manifest file -> sensible default makes a lot of sense. If you're worried people may get confused you can definitely add a little note when it's running with the default to help indicate to people that they may accidentally be searching the wrong registry.