search

Upload / Up1

Client-side encrypted image host web server
MIT License
813 stars 97 forks source link

Replace highlight.js with prism.js? #51

Closed k0nsl closed 8 years ago

k0nsl commented 8 years ago

Would there be any interest in replacing highlight.js with prism.js1?

Refs.

  1. https://github.com/PrismJS/prism

PS: seems like I haven't followed this project for sometime now, as it was still written in Golang when I used it 😂

andre-d commented 8 years ago

The reason we use highlight is the language auto detection. It we can replace that portion I would look into replacing with one of many different highlight engines. On Feb 20, 2016 4:26 AM, "k0nsl" notifications@github.com wrote:

Would there be any interest in replacing highlight.js with prism.js1?

  1. https://github.com/PrismJS/prism

PS: seems like I haven't followed this project for sometime now, as it was still written in Golang when I used it 😂

— Reply to this email directly or view it on GitHub https://github.com/Upload/Up1/issues/51.

k3d3 commented 8 years ago

PS: seems like I haven't followed this project for sometime now, as it was still written in Golang when I used it 😂

It actually still is written in Golang, however we've added a second Node server for the time being. Both are currently maintained and we don't have any plans to deprecate either one at the moment.

andre-d commented 8 years ago

The advantage of the Go server is that it is dependency free beyond Go itself

k0nsl commented 8 years ago

@andre-d: Yes, that's the issue I stumbled upon when I tried to replace it myself. I couldn't be bothered with it and reverted back to the latest release of highlight.js :)

@k3d3: Thanks for the clarification.