Dependency fixes, AmazonS3Client properties more configurable, Non UnitTests 'removed' and URI encoding added.

jarnaiz commented 9 years ago

Hi sbeimin,

Thanks for your commit. I send to you an email two days ago and i dont know if the email arrived. Im going to review this pull review over the week.

Thanks in advance! :+1:

sbeimin commented 9 years ago

I've read and replied to your email @jarnaiz

coveralls commented 9 years ago

Coverage decreased (-6.78%) when pulling d9f6d4fd9f43c5b202e2fa2d47d79a875b1ecc8e on sbeimin:master into 7456197a16666182d9627ecb072325ca71db2f07 on Upplication:master.

jarnaiz commented 9 years ago

I think would be great create some tests to verify the new functionality, please help me / fix me defining the tests:

[ ] As a developer I want to set many endpoints with different creadentials
[ ] As a developer I want to set my credentials in the uri
[ ] As a developer I want to override the AmazonS3 properties
[ ] As a developer I want to override the AmazonS3 properties: TODO: set each prop.

Other tasks:

[ ] Add unit test for S3KeyHelper
[ ] Add javadoc to S3KeyHelper
[ ] Test to cover files with spaces like 'ALFA ROMEO'
[ ] Create Maven profile for integration-tests

sbeimin commented 9 years ago

@jarnaiz I'll close this pull request in favor of #24 .

Upplication / Amazon-S3-FileSystem-NIO2

Dependency fixes, AmazonS3Client properties more configurable, Non UnitTests 'removed' and URI encoding added. #23