Upplication / Amazon-S3-FileSystem-NIO2

An S3 File System Provider for Java 7
MIT License
122 stars 67 forks source link

Apache Tika should be an optional module #41

Open pditommaso opened 9 years ago

pditommaso commented 9 years ago

Since Java JSR-203 provides a default implementation for Files.probeContentType method I would suggest to leave the custom implementation for FileTypeDetector based on on Apache Tika optionally configurable the user.

That would simply require to do not include the java.nio.file.spi.FileTypeDetector file in the jar META-INF directory.

jarnaiz commented 9 years ago

Hi Paolo,

why you don't want to use tika? The default implementation have a bug or missed feature in mac os: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7133484

The Tika library works well and the client don't have to configure anything extra to use it.

pditommaso commented 9 years ago

Hi Javier, in my case it isn't a critical feature (and also that bug has been fixed in Java 8) so in my opinion it would make sense to have Tika as an optional configurable module.