search

Upplication / Amazon-S3-FileSystem-NIO2

An S3 File System Provider for Java 7
MIT License
122 stars 67 forks source link

S3SeekableByteChannel always uploads the data on close() #50

Closed bgd42 closed 8 years ago

bgd42 commented 8 years ago

Hi all,

When we create a S3SeekableByteChannel with option READ, then we should not upload the data on close(). I understand this functionality for other options (like WRITE) when we need to sync the changes with the remote S3, but in this case it is very confusing and decreases the performance of this implementation.

For now I have workarounds for this, but I think this issue deserves some attention in the future.

Cheers, Bogdan

jarnaiz commented 8 years ago

I think the problem is fixed but I have some doubts about the StandardOpenOptions combinations. If you see something wrong plz, tell me.

Thanks for your comments!