Upplication / Amazon-S3-FileSystem-NIO2

An S3 File System Provider for Java 7
MIT License
122 stars 67 forks source link

Issues with Travis CI build failures #74

Open tmrn411 opened 7 years ago

tmrn411 commented 7 years ago

I noticed my recent pull request failed the Travis CI check. All the failures occur on the integration tests. When I force those to run locally I don't get most of the failures (there is 1 I think may be related to changes in my pull request).

I'm wondering if these may be due to the fact that the source tree is missing 'src/test/resources/amazon-test.properties'. It looks like it may be causing Environment.getBucket to fail during test setup.

Also, I'm wondering why the maven config is setup to only run the integration tests when they run on the Travis environment. Is it because some of the tests are looking environment variables? If so, my recent pull request also included some routines to alter the environment variables (just locally within the current process) so that test setup can control what subsequent calls to System.getenv

ryan-williams commented 6 years ago

Also seeing integration tests fail with no useful output on #107.

I can reproduce similar output locally by running:

TRAVIS=true mvn integration-test

I see a list of "Tests in error" like:

Tests in error:
  lookup_S3Object_when_S3Path_is_file_and_exists_other_starts_with_same_name(com.upplication.s3fs.S3UtilsIT)
  lookup_S3Object_when_S3Path_is_file(com.upplication.s3fs.S3UtilsIT)
  lookup_S3Object_when_S3Path_is_a_directory(com.upplication.s3fs.S3UtilsIT)
  lookup_S3PosixFileAttributes_when_S3Path_is_file(com.upplication.s3fs.S3UtilsIT)
  lookup_S3Object_when_S3Path_is_a_directory_and_exists_other_directory_starts_same_name(com.upplication.s3fs.S3UtilsIT)
  lookup_S3PosixFileAttributes_when_S3Path_is_a_directory_and_is_virtual(com.upplication.s3fs.S3UtilsIT)
  lookup_S3Object_when_S3Path_is_a_directory_and_is_virtual(com.upplication.s3fs.S3UtilsIT)
  lookup_S3BasicFileAttributes_when_S3Path_is_file(com.upplication.s3fs.S3UtilsIT)
  lookup_S3PosixFileAttributes_when_S3Path_is_a_directory_and_is_not_virtual_and_no_content(com.upplication.s3fs.S3UtilsIT)
  lookup_S3BasicFileAttributes_when_S3Path_is_a_directory_and_is_not_virtual_and_no_content(com.upplication.s3fs.S3UtilsIT)
  lookup_S3BasicFileAttributes_when_S3Path_is_a_directory_and_is_virtual(com.upplication.s3fs.S3UtilsIT)
  newByteChannelWrite(com.upplication.s3fs.FileSystemProvider.NewByteChannelIT)
  …

Curiously, the mvn command exits with code 0. Not sure why that would happen, and why it's apparently exiting non-zero in Travis (since the build is failing).