UppsalaNLP / uuparser

A transition-based parser for Universal Dependencies with BiLSTM word and character representations.
Apache License 2.0
80 stars 25 forks source link

Packaging #17

Closed LoicGrobol closed 4 years ago

LoicGrobol commented 4 years ago

This is meant to fix https://github.com/UppsalaNLP/uuparser/issues/16 by adding Python packaging.

In order to conform to the structure recommended by the official packaging guide I have reworked the directories, that can be changed back (although I don't recommend it).

The installation can be tested with

pip install --no-cache-dir cython
pip install --no-cache-dir --extra-index-url https://test.pypi.org/simple uuparser

(--no-cache-dir to be correctly simulate a fresh install, separate Cython install required for Python > 3.7 until DyNet either release a new version integrating https://github.com/clab/dynet/pull/1608 or release Python 3.8 wheels)

Other changes:

ToDo

LoicGrobol commented 4 years ago

@mdelhoneux (or someone else) Can you check if the metadata in setup.cfg are correct?

mdelhoneux commented 4 years ago

@mdelhoneux (or someone else) Can you check if the metadata in setup.cfg are correct?

Yep looks good! This is great, thanks!

LoicGrobol commented 4 years ago

@mdelhoneux Cool, then unless there are specific things you'd like to test, this is ready to merge :-) I will delete the test upload on test.pypi and it will just need two commands to upload it on pypi, it's probably better if it's done by a maintainer than by me

LoicGrobol commented 4 years ago

Woops, found a tiny bug, please don't merge just yet

mdelhoneux commented 4 years ago

ok, cool!

LoicGrobol commented 4 years ago

Ok, ready to merge now!