Closed LoicGrobol closed 4 years ago
@mdelhoneux (or someone else) Can you check if the metadata in setup.cfg are correct?
@mdelhoneux (or someone else) Can you check if the metadata in setup.cfg are correct?
Yep looks good! This is great, thanks!
@mdelhoneux Cool, then unless there are specific things you'd like to test, this is ready to merge :-) I will delete the test upload on test.pypi and it will just need two commands to upload it on pypi, it's probably better if it's done by a maintainer than by me
Woops, found a tiny bug, please don't merge just yet
ok, cool!
Ok, ready to merge now!
This is meant to fix https://github.com/UppsalaNLP/uuparser/issues/16 by adding Python packaging.
In order to conform to the structure recommended by the official packaging guide I have reworked the directories, that can be changed back (although I don't recommend it).
The installation can be tested with
(
--no-cache-dir
to be correctly simulate a fresh install, separate Cython install required for Python > 3.7 until DyNet either release a new version integrating https://github.com/clab/dynet/pull/1608 or release Python 3.8 wheels)Other changes:
uuparser
python >= 3.6
, if this is an issue, it can be changed back.barchybrid
touuparser
, which seemed more fitting but this is purely cosmetic and easy to changetox
)ToDo