UpsilonNumworks / Upsilon

Upsilon, an OS forked from Omega for your Numworks calculator
https://getupsilon.web.app/
Other
209 stars 61 forks source link

[build] update apps_layout.csv from EPSILON_APPS flag in make command #332

Closed AngeDieu closed 1 year ago

AngeDieu commented 1 year ago

I did it ! It's my first real modification of Upsilon (and of any c++ project) ! :tada:

I fixed a bug : When you buid Upsilon changing the app order with the EPSILON_APPS flag, the layout stayed the old one, and the app you clicked on wasn't the shown one. It's easier to understand with screenshots: image and when I click on it, it opens the python app ! image

To fix it, the apps_layout.csv is automaticly updated from the EPSILON_APPS flag in the make command.

The Default and HidePython layouts are both updated because of the same bug: the layout and the content of the home app isn't synchronized (pressing the graph icon doen't mean go to the graph icon, but go to the app n°x, which can be different from the graph app).

github-actions[bot] commented 1 year ago
.text .rodata .bss .data Total (RAM) Total (ROM)
Base 822196 bytes 477549 bytes 226520 bytes 1816 bytes 228336 bytes 1301561 bytes
Head 822196 bytes 477549 bytes 226520 bytes 1816 bytes 228336 bytes 1301561 bytes
+0 bytes +0 bytes +0 bytes +0 bytes +0 bytes +0 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %
AngeDieu commented 1 year ago

I first tried to do this only from the ~/Makefile, adding

apps_layout_list = $(foreach i, $${EPSILON_APPS}, $(if $(filter external, $(i)),,"$(i),"))

.all :
  @echo "Default,$(apps_layout_list)" > apps/home/apps_layout.csv
  @echo "HidePython,$(apps_layout_list)" >>apps/home/apps_layout.csv

But I didn't figure out how to always execute it, whatever we compile. Maybe someone can tell me (at least to know how to do it) ? Thanks.

github-actions[bot] commented 1 year ago
.text .rodata .bss .data Total (RAM) Total (ROM)
Base 822196 bytes 477549 bytes 226520 bytes 1816 bytes 228336 bytes 1301561 bytes
Head 822196 bytes 477549 bytes 226520 bytes 1816 bytes 228336 bytes 1301561 bytes
+0 bytes +0 bytes +0 bytes +0 bytes +0 bytes +0 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %