UpstandingHackers / hammer

Parser combinators for binary formats, in C. Yes, in C. What? Don't look at me like that.
GNU General Public License v2.0
430 stars 40 forks source link

cross-compile: bad $PKG_CONFIG_PATH #143

Open rkjdid opened 8 years ago

rkjdid commented 8 years ago

I had some trouble x-compiling hammer, pkg-config was giving me the 'glib-2.0.pc' not found. I'm not really sure what env variable got lost or how it did, but a friend helped me fix it with the following patch :

--- hammer-1.0.0-rc3.orig/SConstruct    2014-04-14 00:55:56.000000000 +0200
+++ hammer-1.0.0-rc3/SConstruct 2015-09-16 16:10:37.523867180 +0200
@@ -98,7 +98,7 @@
     env.Replace(CC="clang",
                 CXX="clang++")

-env["ENV"].update(x for x in os.environ.items() if x[0].startswith("CCC_"))
+env["ENV"].update(x for x in os.environ.items())

 #rootpath = env['ROOTPATH'] = os.path.abspath('.')
 #env.Append(CPPPATH=os.path.join('#', "hammer"))
abiggerhammer commented 8 years ago

I am way behind on issues, and am very sorry about that.

Anyway, git blame says that line was my fault. Mind filing a PR for it? I know it's a one-liner, but the record should still show your contribution.