remove implicit addition of "TT_" prefix to token-type macros, because i...

UpstandingHackers / hammer

Parser combinators for binary formats, in C. Yes, in C. What? Don't look at me like that.

GNU General Public License v2.0

430 stars 40 forks source link

remove implicit addition of "TT_" prefix to token-type macros, because i... #88

Closed pete- closed 10 years ago

pete- commented 10 years ago

...t's confusing to require them in one place but not others.

Just changing these two lines did not break any of the tests that weren't already broken on my (ia32) machine, and there are no other instances of "\WTT_\W" in the source, so I'm hopeful this is sufficient.

thequux commented 10 years ago

This change breaks the examples. There are currently no tests for them (not your problem), but they should at least build.

You can try building them with scons examples.

pete- commented 10 years ago

Cool, I'll fix them soon.

As an aside, it would be nice if the Dev Guide had a "what to run after you make a change" section, including things like building the examples and running the benchmarks. (I had to dig around a bit to figure out the latter.)

pete- commented 10 years ago

I dug around quite a bit more and it seems the implicitness of the TT_ prefix is more deeply embedded than I anticipated. I hereby revoke this PR!