search

Upstatement / quickshare

Simple way of implementing social media share buttons
26 stars 2 forks source link

Twitter widgets conflict? #19

Closed yuvilio closed 9 years ago

yuvilio commented 9 years ago

Noticed that for a site that uses twitters widget.js , the share functionality doesn't seem to work? (clicking on the link ). I've used this before and it works great.

Then tried it on a site that had this snippet, used to show twitter widgets like timelines, 

<script src="//platform.twitter.com/widgets.js" async></script>

and the twitter clicking the twitter quickshare links didn't do anything.

Using version 1.3.4 .

emmagard commented 9 years ago

@yuvilio Thanks for filing this issue. I'm taking a look at this problem this week.

yuvilio commented 9 years ago

Sweet. Thanks, @emmagard. If it's reproducible and addressable, I'm happy to retest.

emmagard commented 9 years ago

@yuvilio This has been resolved with the last PR. Let me know if you are still experiencing any other conflicts. Thanks again for pointing out this issue.

yuvilio commented 9 years ago

Nice. I just tried it with quickshare 1.3.6 and the twitter share button now works, even with the widgets.js library there. Thanks @emmagard !