search

Upstatement / quickshare

Simple way of implementing social media share buttons
26 stars 2 forks source link

Facebook Icon undefined #8

Closed jarednova closed 10 years ago

jarednova commented 10 years ago

When I try to implement FontAwesome, the twitter icon appears, but not facebook....

screen shot 2014-05-12 at 5 27 29 pm

screen shot 2014-05-12 at 5 26 39 pm

Here's my HTML...

<nav class="social-media">
            <a class="qs-link" data-qs-service="twitter"><i class="qs-icon"></i>Twitter</a>
            <a class="qs-link" data-qs-service="facebook"><i class="qs-icon"></i>Facebook</a>
            <a class="qs-link" data-qs-service="github"><i class="qs-icon"></i>GitHub</a>
        </nav>

... I know GitHub isn't implemented yet -- you can ignore that piece as a part of this issue

thetmkay commented 10 years ago

Sorry, Facebook's service is 'facebook-share' not 'facebook'. That could be considered a UX bug.