Upstatement / routes

Simple routing for WordPress
188 stars 38 forks source link

Apply double-slash patch #20

Closed jarednova closed 4 years ago

jarednova commented 4 years ago

Fix for #12

patrickbjohnson commented 4 years ago

@jarednova thank you for pushing this! However looks like this double slash still exists.

jarednova commented 4 years ago

@patrickbjohnson well that's no good! When you say the problem still exists, is that based on running this repo? A composer distribution? A Timber distribution that includes it?

patrickbjohnson commented 4 years ago

@jarednova Hey. Sorry I didn't expand in my initial comment. I'm pulling in this lib via composer and looks like the version composer references still has the error.

This may be a different issue altogether but also looks like within composer the only way to import is using the version: "*"

jarednova commented 4 years ago

@patrickbjohnson Hmmmm, I tried running this in terminal and things seemed to work:

Jareds-MacBook-Air:routes_test jared$ composer require upstatement/routes 0.6
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 3 installs, 0 updates, 0 removals
  - Installing composer/installers (v1.7.0): Loading from cache
  - Installing altorouter/altorouter (v1.2.0): Loading from cache
  - Installing upstatement/routes (0.6): Downloading (100%)         
Writing lock file
Generating autoload files
Jareds-MacBook-Air:routes_test jared$ 

can you post a version of the exact commands or Composer file you've got so I can see if I can replicate the error?

n3storm commented 4 years ago

Updated timber today which updated routes and everthing is OK

jarednova commented 4 years ago

Great! glad to hear that went through w/o a hitch @n3storm