search

Upstatement / routes

Simple routing for WordPress
188 stars 38 forks source link

Fatal error in WordPress 4.6 #5

Closed stewarty closed 8 years ago

stewarty commented 8 years ago

WordPress 4.6 now includes Ryan McCue's Requests Library.

When using Routes it is possible to get a Fatal Error as you are also including this Library but in an older version it would seem? Anyway, The Request_Response Classes aren't the same. Yours is getting used in preference to the included one. This causes the is_redirect() method to be reported as missing and WP has a fatal crash.

Fix in the meantime is to just delete the Requests Folder in vendor

jarednova commented 8 years ago

Thanks for the heads-up on this @stewarty, sounds like I need to do some 4.6 testing! Could you point me to where in the code the conflicting classes are? Is this something in this repo, or one of the dependencies I'm using? (like AltoRouter)

stewarty commented 8 years ago

It's in your dependencies. rmmcue/requests

Is it actually being used?

The Resquest_Response class is conflicting!

Sent from my iPhone

On 25 Aug 2016, at 14:34, Jared Novack notifications@github.com wrote:

Thanks for the heads-up on this @stewarty, sounds like I need to do some 4.6 testing! Could you point me to where in the code the conflicting classes are? Is this something in this repo, or one of the dependencies I'm using? (like AltoRouter)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jarednova commented 8 years ago

Hi @stewarty, I'm sorry but I'm not able to find rmmcue/requests in the dependencies or elsewhere in the code. The dependencies I'm using are just Altorouter, Composer and PHP. Can you point to where exactly this exists? Is this the current master or a past version of this repo?

stewarty commented 8 years ago

Gottya - its actually in wp-cli

https://github.com/wp-cli/wp-cli/blob/master/composer.json#L17

jarednova commented 8 years ago

I will crush them.