Remove ACF and WP Migrate plugins from composer files

Upstatement / skela-wp-theme

An Upstatement-flavored starter theme for WordPress

MIT License

63 stars 11 forks source link

Remove ACF and WP Migrate plugins from composer files #46

Closed bchiang7 closed 4 years ago

bchiang7 commented 4 years ago

Changes

Removes composer.lock entirely to prevent committing license keys

Update: Travis build fails now... should we just remove the ACF & WP Migrate packages from composer.json entirely?

beahuang commented 4 years ago

Maybe we should comment those packages out?

bchiang7 commented 4 years ago

I don't think composer.json likes commented out code, I think the quick and dirty solution might be to just remove those packages from the composer.json and add a code block to the readme where you can copy & paste them back in if you have a key

beahuang commented 4 years ago

@bchiang7 i'm into that approach as well

mgburns commented 4 years ago

@bchiang7 @beahuang Agreed! Let's go that route for the sake of simplicity.