Upstatement / skela-wp-theme

An Upstatement-flavored starter theme for WordPress
MIT License
63 stars 11 forks source link

Add M1 Compatibility & Pull in 2022 ESK updates #79

Closed bchiang7 closed 1 year ago

bchiang7 commented 1 year ago

Context

Was trying to run the ups.com repo (which is based on Skela) and hit some snags going through the setup steps with my M1 mac!

Changes

Updates from: https://github.com/Upstatement/editorial-starter-wp-theme/pull/179/files https://github.com/Upstatement/editorial-starter-wp-theme/pull/190 https://github.com/Upstatement/editorial-starter-wp-theme/pull/191 and others

How To Test

With an M1 mac go through installation steps https://github.com/Upstatement/skela-wp-theme#-installation

bchiang7 commented 1 year ago

@ALJ @braican @gvjacob would really appreciate a quick review this week! these are all changes that have been implemented in WSK (mainly authored by gino), so I'm not so worried about bugs. I just want to make sure it doesn't just work on my machine before I merge

gvjacob commented 1 year ago

@bchiang7 Install went through! I was able to start the app but it's https://skela.ups.dock is showing the Ups Dock dashboard only without the Skela app there.

CleanShot 2023-01-18 at 10 09 44

Maybe something to do with this?

CleanShot 2023-01-18 at 10 24 08

bchiang7 commented 1 year ago

@gvjacob hmm I just tried again after restarting ups dock because it seemed like my ups.dock dashboard was cached and everything still works for me. could you test again with these extra steps?

Looks like this for me

image
gvjacob commented 1 year ago

@bchiang7 hmm the URL is still resolving to the ups dock dashboard for me after those steps. I'll give it a look a bit later today but would also appreciate a look from @ALJ and @braican

bchiang7 commented 1 year ago

@bchiang7 hmm the URL is still resolving to the ups dock dashboard for me after those steps. I'll give it a look a bit later today but would also appreciate a look from @ALJ and @braican

@gvjacob Hmmmmm I just compared all the docker related files to WSK and they're identical, save for the few places I replaced editorial-starter.ups.dock with skela.ups.dock. Did you remember to copy over the .env file? I wonder if installing WSK works on your machine?