search

UpstreamDataInc / goosebit

A simplistic, opinionated remote update server implementing hawkBit™'s DDI API.
https://goosebit.rtfd.io
Apache License 2.0
18 stars 5 forks source link

Auto assign milestone to PR or issue based on tag #115

Closed b-rowan closed 2 months ago

b-rowan commented 2 months ago

Assigns a milestone to an issue or PR automatically when a tag matching a v*.*.* semantic version is added.

tsagadar commented 2 months ago

I am not that familiar with this. My current understanding is that these actions will automatically assign/unassign issues/PRs to milestones if a label is used matching a version? Shouldn't we just directly set those milestones instead of labels (personally I was not that aware about milestones, but sure the better approach).

What confused me initially was the term "tag". So I assumed git tags. Maybe better to use label?

b-rowan commented 2 months ago

I am not that familiar with this. My current understanding is that these actions will automatically assign/unassign issues/PRs to milestones if a label is used matching a version? Shouldn't we just directly set those milestones instead of labels (personally I was not that aware about milestones, but sure the better approach).

I sort of agree, but the tagging system is a bit nicer to work with I think. Basically the goal of this PR is to use tags to synchronize with milestones, as milestones seem to track progress better, but tags are easier to assign and work with. We create the tags and then the rest gets automated.

If the consensus is a preference of milestone only for versions, I'm ok with that too, but this actually seemed less confusing to me.

What confused me initially was the term "tag". So I assumed git tags. Maybe better to use label?

Yeah, this makes sense. I was a bit confused too when I wrote this, I'll swap everything over to labels tomorrow.

easybe commented 2 months ago

If the consensus is a preference of milestone only for versions, I'm ok with that too, but this actually seemed less confusing to me.

Yes, we should use milestones instead of labels for versions, because that is what the feature is for. Even though I was aware of milestones, I started using labels because it was the easiest at the time.

IMHO we should only introduce a new CI job (and complexity) if there is an actual problem to solve.