UpstreamDataInc / goosebit

A simplistic, opinionated remote update server implementing hawkBit™'s DDI API.
https://goosebit.rtfd.io
Apache License 2.0
18 stars 5 forks source link

Remove IP tracking #165

Closed b-rowan closed 3 weeks ago

b-rowan commented 1 month ago

Fixes: #164

jameshilliard commented 1 month ago

I'm thinking it's better to make this a config flag to disable rather than remove the columns entirely.

easybe commented 3 weeks ago

I'm thinking it's better to make this a config flag to disable rather than remove the columns entirely.

Both is fine for us. However, I guess this can easily be brought back when needed. IMHO we should focus on getting the core functionality as stable/usable as possible, so less is more. For us, the most important thing is scalability, as we have a lot of devices.

b-rowan commented 3 weeks ago

I think based on recent discussion that this should be reworked to a config option. Should be pretty simple, it will only instantiate the middleware if the config flag is enabled.