Remove WebSocket support?

tsagadar commented 3 hours ago

Currently WebSockets are only used for realtime updates of device logs.

Drawbacks I see

Added code complexity (eg. there are no tests yet for this endpoint, additional package)
Deployment complexity (eg. needs special handling if hosted in AWS)
Scalability issue: assuming #197 gets merged, it is the only functionality that has global state and makes it hard to scale to multiple workers if required.

Also: enabling WebSockets for the other screens could be substantial work and not worth the effort IMHO.

Proposal: eliminate WebSockets and add reload button in device log screen.

Thoughts?

b-rowan commented 2 hours ago

Sure, seems like a good idea if it's causing issues. Would likely want one of those auto refresh timers with a button I think?

tsagadar commented 2 hours ago

You are right. Or thinking about it: just re-using the reload interval the other screens have as well.

UpstreamDataInc / goosebit