search

UpstreamDataInc / goosebit

A simplistic, opinionated remote update server implementing hawkBit™'s DDI API.
https://goosebit.rtfd.io
Apache License 2.0
18 stars 3 forks source link

Migrate settings to pydantic #67

Closed b-rowan closed 2 months ago

b-rowan commented 2 months ago

Do we want to try using the settings built into pydantic? Since this is already a dependency of FastAPI, I think it makes more sense.

https://docs.pydantic.dev/latest/concepts/pydantic_settings/

easybe commented 2 months ago

Fine by me, as long as the environment variables are ALL_CAPS.

b-rowan commented 2 months ago

Fine by me, as long as the environment variables are ALL_CAPS.

Yep, technically theyre case insensitive, so it can do both :+1:

b-rowan commented 2 months ago

FYI I'm fine with merging #64 in the meantime until we can format a schema for this, this will be a bit more work than what has been done there.