UptownResearch / pyTokenSpike

intial work on pyTokens
0 stars 0 forks source link

Added ethlint as a dependency. #1

Closed alcueca closed 4 years ago

alcueca commented 4 years ago

As a first PR, let's add ethlint as a dependency. Having a consistent code style doesn't add any additional work in the long run, and reduces friction when reviewing code.

I use yarn usually, after running that to build the packages you can run yarn lint to see the output.

The linting rules are set in .soliumrc, and we can change them if we find them inappropriate (usually the discussion is about the max length allowed in each line).

In my projects I usually set a clean lint run as a condition for merging branches. Not going to propose that here yet, but as the project grows it will be necessary.