search

UptownResearch / pyTokenSpike

intial work on pyTokens
0 stars 0 forks source link

Extract math functions to a library #5

Closed alcueca closed 4 years ago

alcueca commented 4 years ago

https://github.com/UptownResearch/pyTokenSpike/blob/a71909b85e484ff565554672b0dcaacb607c6b58/dapp/contracts/pytoken.sol#L124

Also consider reusing Synthetix SafeDecimalMath.sol, or HQ20 DecimalMath.sol instead of rolling out our own.

aniemerg commented 4 years ago

Definitely would prefer not to roll my own. Does either of those achieve what we need?

alcueca commented 4 years ago

Let's use HQ20 DecimalMath.sol, for now it achieves all that we need and is easy to use.

I'll fix #7 and #8 at the same time.