search

UrAvgCode / Chooser

An Android app to randomly select fingers on the screen
GNU General Public License v3.0
81 stars 3 forks source link

Enable edge-to-edge by default #8

Closed pacjo closed 5 months ago

pacjo commented 5 months ago

Hi, I'm not sure you want this change, but in my opinion it looks much better now on devices with all sorts of display cutouts, below is a short comparison.

Also it will be the default on devices targeting SDK 35, so I tried bumping that too and it didn't result in any issues.

If you disagree with the change, or you'd like to do it differently, feel free to close this PR or request modifications to it.

comparision

before: (notice black bar at the top of the screen (there's also one around navigation pill / buttons, but it's less visible)

https://github.com/UrAvgCode/Chooser/assets/56438628/68e769a3-babf-40f2-b1d0-d889e2d166d0

after: (whole screen is used for effects, with no black bars)

https://github.com/UrAvgCode/Chooser/assets/56438628/ab4ee3e9-5630-40d3-95b0-1c749a6f82e3

UrAvgCode commented 5 months ago

the changes look good from my testing as well, i'll go ahead and merge it, thanks for your contribution